Open
Conversation
berquist
added
Implementation
Member
|
I do intend to eventually add code to this chapter, so this PR is a good idea in principle; however, I don't know enough JS to say whether this is a good, fundamental implementation of a stack or queue in that language. right now, my understanding is that this code goes a bit futher to allow for outputing the maximum or minimum element in the stack, which is useful, but not what I was thinking of for this chapter. |
Member
|
[lang: javascript] |
henrikac
reviewed
Oct 19, 2021
Contributor
henrikac
left a comment
henrikac
left a comment
There was a problem hiding this comment.
The indentation is not consistent in MixMaxStack but this should be a quick fix :)
| this.minMaxStack =[]; | ||
| this.stack = []; | ||
| } | ||
| peek(){ |
Contributor
There was a problem hiding this comment.
This chapter uses the words top and front for stacks and queues. Maybe rename peek to top to use the same words as used in the chapter?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a stack class example in js & added imported the code into the md file.